From 8b368d010f772fba123f198a5077d6778b76cae2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Florian=20M=C3=BCllner?= Date: Wed, 7 Aug 2019 02:26:32 +0200 Subject: [PATCH] environment: Fix transition callback This is rather embarrassing - we currently confuse the transition with the finished parameter, which means we always run the onComplete handler no matter whether the transition was interrupted or actually completed. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/668 --- js/ui/environment.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/ui/environment.js b/js/ui/environment.js index b00b74dd9..a248ea069 100644 --- a/js/ui/environment.js +++ b/js/ui/environment.js @@ -64,7 +64,7 @@ function _trackTransition(transition, callback) { if (_easingTransitions.has(transition)) transition.disconnect(_easingTransitions.get(transition)); - let id = transition.connect('stopped', isFinished => { + let id = transition.connect('stopped', (t, isFinished) => { _easingTransitions.delete(transition); callback(isFinished); }); -- 2.39.5